Skip to content

Updates for new SDK#26

Merged
KenVanHoeylandt merged 1 commit intomainfrom
update-apps-for-sdk-changes
Feb 15, 2026
Merged

Updates for new SDK#26
KenVanHoeylandt merged 1 commit intomainfrom
update-apps-for-sdk-changes

Conversation

@KenVanHoeylandt
Copy link
Contributor

@KenVanHoeylandt KenVanHoeylandt commented Feb 15, 2026

Summary by CodeRabbit

  • Refactor
    • Updated UI layout handling in GPIO, Snake, and TwoEleven apps to determine element spacing and toolbar heights based on UI density setting rather than UI scale approach.

@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2026

📝 Walkthrough

Walkthrough

The changes involve replacing UI scale-based handling with UI density-based handling across three app components. Method signatures that previously accepted UiScale parameters now accept UiDensity parameters. The implementations use lvgl_get_ui_density() instead of tt_hal_configuration_get_ui_scale() to determine the UI configuration. Conditional checks comparing against LVGL_UI_DENSITY_COMPACT replace previous UiScale comparisons. The header dependency shifts from tt_hal.h to tactility/lvgl_module.h. These changes affect toolbar and spacing calculations in GPIO, Snake, and TwoEleven applications.

🚥 Pre-merge checks | ✅ 2 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is vague and generic; it does not convey what specific SDK changes are being addressed or which components are affected. Consider a more descriptive title that explains the key change, such as 'Replace UI scale with UI density in GPIO, Snake, and TwoEleven apps' or 'Update apps to use LVGL UI density API'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-apps-for-sdk-changes

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
Apps/Snake/main/Source/Snake.cpp (1)

45-51: Duplicated getToolbarHeight across Snake and TwoEleven.

This function is identical to TwoEleven.cpp (lines 42–48). Consider extracting it into a shared utility header to avoid divergence if the values ever need updating.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KenVanHoeylandt KenVanHoeylandt merged commit 1443a29 into main Feb 15, 2026
12 checks passed
@KenVanHoeylandt KenVanHoeylandt deleted the update-apps-for-sdk-changes branch February 15, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant